feat: prefix allows all version identifiers

go-nv / goenv

:blue_car: Like pyenv and rbenv, but for Go.

https://github.com/go-nv/goenv

MIT License

2.05k stars 245 forks source link

feat: prefix allows all version identifiers #383

Closed reneleonhardt closed 3 months ago

reneleonhardt commented 3 months ago

Features

goenv prefix supports the same installed version identifiers like local or global
goenv prefix latest -> 1.22.3 (latest installed version)
goenv prefix system -> system Go location if installed
goenv prefix 1 -> 1.22.3 (latest installed major version)
goenv prefix 22 -> 1.22.3 (latest installed minor version when combined with a major version)
goenv prefix 1.22 -> 1.22.3 (latest installed minor version)
Offer all installed versions plus latest and system as completions

Fixes

Usage information and tests by introducing new helper functions

Changed

Using latest patch version no longer displayed (prefix contains the found version already)

reneleonhardt commented 3 months ago

Asserting stdin tricks didn't work, I had to write new helper functions. But on the bright side, the tests are working now because of that and I fixed multiple old tests and some usages.

I still don't understand the intention why --complete and completions have different outputs though... 🤷

ChronosMasterOfAllTime commented 3 months ago

@reneleonhardt are you interested in becoming a bona fide contributor role? I can add you which will give you more privileges to review/merge PRs and add releases etc

reneleonhardt commented 3 months ago

Hey Chronos, wow, thank you for the offer! Actually I'm no Go developer, still waiting for v2 to iron out the kinks and save me many headaches 😅 But it could be interesting to learn more about it because a big part of the k8s ecosystem seems to prefer it, let's try and see how it goes!

ChronosMasterOfAllTime commented 3 months ago

Hey Chronos, wow, thank you for the offer! Actually I'm no Go developer, still waiting for v2 to iron out the kinks and save me many headaches 😅 But it could be interesting to learn more about it because a big part of the k8s ecosystem seems to prefer it, let's try and see how it goes!

Done! You should have gotten an invite. For what it's worth, go 1.22 is actually quite powerful. I have been using go since 1.9 and the differences are night and day. I have been developing on golang for 5 years now, and have found it quite intriguing and simple. Does it have its drawbacks? Of course! But I feel the pros out weigh the cons.