search

go-openapi / spec

openapi specification object model
Apache License 2.0
389 stars 98 forks source link

Omit to marshal response description as JSON when $ref is defined #127

Closed fredbi closed 3 years ago

fredbi commented 3 years ago

Modifying the "omitempty" tag in response.Description and SecurityScheme.AuthorizationURL (originally intended to fix go-swagger/go-swagger#1775) had unintended consequences like:

Signed-off-by: Frederic BIDON fredbi@yahoo.com

codecov[bot] commented 3 years ago

Codecov Report

Merging #127 (cc15ba1) into master (19e53be) will increase coverage by 0.91%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   57.50%   58.42%   +0.91%     
==========================================
  Files          25       25              
  Lines        1871     1912      +41     
==========================================
+ Hits         1076     1117      +41     
  Misses        615      615              
  Partials      180      180
Impacted Files Coverage Δ
response.go 70.17% <100.00%> (+11.63%) :arrow_up:
security_scheme.go 84.61% <100.00%> (+9.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19e53be...cc15ba1. Read the comment docs.