search

go-openapi / spec

openapi specification object model
Apache License 2.0
389 stars 98 forks source link

fix(expand): parameters & responses should properly follow remote doc resolution when SKipSchema #183

Closed fredbi closed 8 months ago

fredbi commented 8 months ago
codecov[bot] commented 8 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b445199) 64.78% compared to head (0bf0cbc) 65.43%.

Files Patch % Lines
expander.go 75.00% 4 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #183 +/- ## ========================================== + Coverage 64.78% 65.43% +0.65% ========================================== Files 29 29 Lines 2845 2844 -1 ========================================== + Hits 1843 1861 +18 + Misses 833 820 -13 + Partials 169 163 -6 ``` | [Flag](https://app.codecov.io/gh/go-openapi/spec/pull/183/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-openapi) | Coverage Δ | | |---|---|---| | [oldstable](https://app.codecov.io/gh/go-openapi/spec/pull/183/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-openapi) | `65.43% <75.00%> (+0.65%)` | :arrow_up: | | [stable](https://app.codecov.io/gh/go-openapi/spec/pull/183/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-openapi) | `65.43% <75.00%> (+0.65%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-openapi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fredbi commented 8 months ago

@casualjim @youyuanwu

Added PRs with additional testing in known repos using this feature:

Seems to work, even if tinkering with this part has always been a bit dodgy...