search

go-openapi / spec

openapi specification object model
Apache License 2.0
389 stars 98 forks source link

Circular refs hang on Windows #64

Closed fredbi closed 6 years ago

fredbi commented 6 years ago

Unit test CircularRefsExpansion fails to detect circular ref and hang on Windows, possibly because of #63.

C:\Users\root\go\src\github.com\go-openapi\spec>go test -v -run CircularRefsExpansion
=== RUN TestCircularRefsExpansion

When looking for circular reference given by non-normalized Ref at https://github.com/go-openapi/spec/blob/1de3e0542de65ad8d75452a595886fdd0befb363/expander.go#L621

the circular ref check fails to identify that the ref has already been encountered

mtfelian commented 6 years ago

Fixed this in PR #67

fredbi commented 6 years ago

Verified. Works. Thanks for the great job