go-openapi / spec

openapi specification object model
Apache License 2.0
389 stars 98 forks source link

go-swagger throws error on windows from this lib #66

Closed mtfelian closed 6 years ago

mtfelian commented 6 years ago

go-swagger throws error on Windows from this lib.

I can't reveal all the details. Stacktrace follows:

2018/03/02 14:10:37
basePath: C:\Go\my_code\src\bitbucket.org\repoowner\reponame\api\core\root
base: c:\Go\my_code\src\bitbucket.org\repoowner\reponame\api\core\root
2018/03/02 14:10:37 calling Resolve with target: {"$ref":"#/definitions/appSettingsParamsBody"}
2018/03/02 14:10:37 loading schema from url: c:\Go\my_code\src\bitbucket.org\repoowner\reponame\api\core\root
[c:]
c:\Go\my_code\src\bitbucket.org\repoowner\reponame\api\core\root
2018/03/02 14:10:37 getting "c:\\Go\\my_code\\src\\bitbucket.org\\repoowner\\reponame\\api\\core\\root" from resolution cache
2018/03/02 14:10:37 got "c:\\Go\\my_code\\src\\bitbucket.org\\repoowner\\reponame\\api\\core\\root" from resolution cache: false
2018/03/02 14:10:37 fetching document at "c:\\Go\\my_code\\src\\bitbucket.org\\repoowner\\reponame\\api\\core\\root"
base: c:\Go\my_code\src\bitbucket.org\repoowner\reponame\api\core\root
2018/03/02 14:10:37 normalizing #/definitions/appSettingsParamsBody against C:\Go\my_code\src\bitbucket.org\repoowner\reponame\api\core\root (#/definitions/appSettingsParamsBody)
2018/03/02 14:10:37 current ref is: #/definitions/appSettingsParamsBody
2018/03/02 14:10:37 current ref normalized file: c:\Go\my_code\src\bitbucket.org\repoowner\reponame\api\core\root#/definitions/appSettingsParamsBody
2018/03/02 14:10:37 loading schema from url: c:\Go\my_code\src\bitbucket.org\repoowner\reponame\api\core\root#/definitions/appSettingsParamsBody
[c:]
c:\Go\my_code\src\bitbucket.org\repoowner\reponame\api\core\root
2018/03/02 14:10:37 getting "c:\\Go\\my_code\\src\\bitbucket.org\\repoowner\\reponame\\api\\core\\root" from resolution cache
2018/03/02 14:10:37 got "c:\\Go\\my_code\\src\\bitbucket.org\\repoowner\\reponame\\api\\core\\root" from resolution cache: false
2018/03/02 14:10:37 fetching document at "c:\\Go\\my_code\\src\\bitbucket.org\\repoowner\\reponame\\api\\core\\root"
+! Panic in Spec Setup (BeforeEach) [0.151 seconds]
Testing API
C:/Go/my_code/src/bitbucket.org/repoowner/reponame/api/core/core_apps_test.go:73
  app registration method [BeforeEach]
  C:/Go/my_code/src/bitbucket.org/repoowner/reponame/api/core/core_apps_test.go:149
    checks that OK
    C:/Go/my_code/src/bitbucket.org/repoowner/reponame/api/core/core_apps_test.go:166

    Test Panicked
    Invalid schema provided to SchemaValidator: open c:\Go\my_code\src\bitbucket.org\repoowner\reponame\api\core\root: The system cannot find the file specified.
    C:/Go/src/runtime/panic.go:505

    Full Stack Trace

I dive into the lib and found that the problem is the CaSe of the Windows drive letter.

Implemented a fix PR #67

fredbi commented 6 years ago

I thought that this was addressed with #58 ?

mtfelian commented 6 years ago

In one more place

fredbi commented 6 years ago

ok. I noted recently some other issues with windows in the spec pkg. At the moment, this package does not run a CI on windows (but we have been discussing that with @casualjim).

mtfelian commented 6 years ago

Solved.