search

go-openapi / spec

openapi specification object model
Apache License 2.0
389 stars 98 forks source link

Relocate relative $ref in response and param schema #78

Closed fredbi closed 6 years ago

fredbi commented 6 years ago

This fixes the case when SkipSchema:true, there are remote $ref in in schema for params and responses declared themselves with $ref (!)

codecov[bot] commented 6 years ago

Codecov Report

Merging #78 into master will increase coverage by 0.2%. The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #78     +/-   ##
=========================================
+ Coverage   40.27%   40.47%   +0.2%     
=========================================
  Files          18       18             
  Lines        1959     1969     +10     
=========================================
+ Hits          789      797      +8     
- Misses        995      996      +1     
- Partials      175      176      +1
Impacted Files Coverage Δ
expander.go 54.54% <60%> (+0.09%) :arrow_up:
ref.go 45.07% <0%> (+2.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16284f9...f9ebe9c. Read the comment docs.

fredbi commented 6 years ago

Tested with analysis/Flatten and with integration in go-swagger. Looks like it works now.