search

go-openapi / spec

openapi specification object model
Apache License 2.0
394 stars 100 forks source link

WIP: Fix circular #81

Closed pytlesk4 closed 6 years ago

pytlesk4 commented 6 years ago

Fixes #79 Fixes #76 Fixes #75 (with some limitations, see #75 and related new issues) Fixes #69

codecov[bot] commented 6 years ago

Codecov Report

Merging #81 into master will increase coverage by 1.91%. The diff coverage is 83.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   40.47%   42.39%   +1.91%     
==========================================
  Files          18       19       +1     
  Lines        1969     2024      +55     
==========================================
+ Hits          797      858      +61     
+ Misses        996      986      -10     
- Partials      176      180       +4
Impacted Files Coverage Δ
debug.go 100% <100%> (ø)
expander.go 57.56% <81.81%> (+3.02%) :arrow_up:
swagger.go 56.92% <0%> (+2.3%) :arrow_up:
header.go 20.93% <0%> (+5.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac0b6b8...64080af. Read the comment docs.

pytlesk4 commented 6 years ago

This looks great.

fredbi commented 6 years ago

ok I let you pass your tests. No rush to merge. On my side, I am pushing a vendor update PR on go-swagger.

pytlesk4 commented 6 years ago

Looks good to merge on my end.

fredbi commented 6 years ago

Just found another little glitch when opts is passed a relative path... So I need one more commit. Also acknowledge #69 fixed (was also circular related)