Closed fredbi closed 7 months ago
Attention: 11 lines
in your changes are missing coverage. Please review.
Comparison is base (
ff196e5
) 92.40% compared to head (486e1d2
) 92.88%.
Files | Patch % | Lines |
---|---|---|
spec.go | 76.66% | 5 Missing and 2 partials :warning: |
default_validator.go | 93.18% | 2 Missing and 1 partial :warning: |
example_validator.go | 95.65% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Readability improvements:
Minor efficiency improvements
In Applies method: reflect replaced by type switch whenever possible
Removed (mostly unusable) debugLog
In object validator:
In schema props: keep arrays of pointers []*SchemaValidator and avoid copying a new schema
In default & example validators:
[]validator slice -> [n]validator array
introduced a benchmark follow-up document, based on the existing Kubernetes API fixture