validation.Required treat type *bool as blank value when it set to false

[siampudan]

I've a struct like this :

type SubCategoryReq struct {
    ProductID          int     `json:"product_id"`
    MerchantID         int     `json:"merchant_id"`
    CategoryID         int     `json:"category_id"`
    ProductName        string  `json:"product_name"`
    ProductDescription string  `json:"product_description"`
    ProductPrice       float64 `json:"product_price"`
    IsAvailable        *bool   `json:"is_available"`
    File               string  `json:"file"`
    FileType           string  `json:"file_type"`
}

and validation struct like this :

func (sc SubCategoryReq) SubCategoryReqValidate() error {
    return validation.ValidateStruct(&sc,
        validation.Field(&sc.CategoryID, validation.Required),
        validation.Field(&sc.ProductName, validation.Required),
        validation.Field(&sc.ProductPrice, validation.Required),
        validation.Field(&sc.ProductDescription, validation.Required),
        validation.Field(&sc.IsAvailable, validation.Required),
    )
}

When i create a request from Postman and set json body payload "is_available" : true the validation.Required treat the IsAvailable field as it is. But, when i set "is_available":false the validation.Required treat the IsAvailable field as blank value { "is_available": "cannot be blank" }. It looks like the validation.Required failed to detect the *bool type when it set to 'false'. To parse the request json payload to the model struct, i use Gin Framework (ShouldBindJSON). Thanks.

[qiangxue]

This is by design, see: https://github.com/go-ozzo/ozzo-validation/blob/master/required.go#L14-L20 You should use NotNil in your case: https://github.com/go-ozzo/ozzo-validation/blob/master/not_nil.go#L13

[siampudan]

hmm, i see. thanks..