An idiomatic Go (golang) validation package. Supports configurable and extensible validation rules (validators) using normal language constructs instead of error-prone struct tags.
MIT License
3.73k
stars
224
forks
source link
[bug] DateRule assumes the date string to be in UTC #166
In the absence of a time zone indicator, Parse returns a time in UTC.
If we provide date strings to DateRule validator without any timezone information, it will always assume it to be in UTC.
On top of it, DateRule doesn't provide any functionality to provide custom time.Location.
This is causing issues because the rule is failing when trying to compute whether the date is actually between minDate and maxDate for some cases where timezone is different and Min and Max are close to the input date string.
This I feel is not the desired behaviour and I think DateRule should instead use time.ParseInLocation with a default timezone and also give users the option to provide a custom timezone if they want.
I am really not sure what should be the default timezone. I can think of 2 possibilities:
Using time.Local as default but that would make it backward incompatible
But if we go with time.UTC as default timezone it will make the validation logic more verbose as we'll have to specify timezone while defining each rule if our local timezone is different than UTC
Description
While using the builtin DateRule validation rule, I noticed that it uses time.Parse.
time.Parse documentation states that:
If we provide date strings to DateRule validator without any timezone information, it will always assume it to be in UTC. On top of it, DateRule doesn't provide any functionality to provide custom time.Location.
This is causing issues because the rule is failing when trying to compute whether the date is actually between minDate and maxDate for some cases where timezone is different and
MinandMaxare close to the input date string.Here's an example demonstrating this behaviour: https://go.dev/play/p/JgKOS6i5oJZ
Proposal
This I feel is not the desired behaviour and I think DateRule should instead use time.ParseInLocation with a default timezone and also give users the option to provide a custom timezone if they want.
I am really not sure what should be the default timezone. I can think of 2 possibilities:
time.Localas default but that would make it backward incompatibletime.UTCas default timezone it will make the validation logic more verbose as we'll have to specify timezone while defining each rule if our local timezone is different than UTCLet me know what do you think.