search

go-ozzo / ozzo-validation

An idiomatic Go (golang) validation package. Supports configurable and extensible validation rules (validators) using normal language constructs instead of error-prone struct tags.
MIT License
3.73k stars 224 forks source link

BreakableErr fix #29 #30

Closed smacker closed 7 years ago

smacker commented 7 years ago

PR follows our discussion in https://github.com/go-ozzo/ozzo-validation/issues/29 Please take a look. If it's okay for you I will add documentation. Thank you in advance.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6f6e897036309411ca208fcd4ea97dbdfe38a817 on smacker:breakable into fd0c62da4c1c99a31921504169596d568902825e on go-ozzo:master.

smacker commented 7 years ago

Travis CI failed with strange error:

coverage: 100.0% of statements
ok      github.com/go-ozzo/ozzo-validation  0.026s

The command "go test -v -covermode=count -coverprofile=coverage.out" exited with 0.
$ $HOME/gopath/bin/goveralls -coverprofile=coverage.out -service=travis-ci
Bad response status from coveralls: 422
{"message":"Couldn't find a repository matching this job.","error":true}
qiangxue commented 7 years ago

Thank you for your PR! I added InternalError type in https://github.com/go-ozzo/ozzo-validation/commit/86433d65440f530b10e94b1b1920895f08b22ec5 which is very similar to what you did.

smacker commented 7 years ago

thank you, sir!