search

go-ozzo / ozzo-validation

An idiomatic Go (golang) validation package. Supports configurable and extensible validation rules (validators) using normal language constructs instead of error-prone struct tags.
MIT License
3.73k stars 224 forks source link

Fix styling on go files. #39

Closed plbogen closed 6 years ago

plbogen commented 6 years ago

There were a couple of big issues. 1) Structs that were returned from public methods were not visible. 2) When a var is set in the same line as it is declared you should use type inference. not: var silly int = 42 but: var silly = 42 3) Errors should be named ErrSomethingBad, not SomethingBadError

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a870d5df72ae1e5ad277cd976224f86baab9fdf9 on plbogen:master into 85dcd8368eba387e65a03488b003e233994e87e9 on go-ozzo:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a870d5df72ae1e5ad277cd976224f86baab9fdf9 on plbogen:master into 85dcd8368eba387e65a03488b003e233994e87e9 on go-ozzo:master.

qiangxue commented 6 years ago

Nice job! Thanks!

plbogen commented 6 years ago

No problem.

On Fri, Jan 19, 2018, 3:21 PM Qiang Xue notifications@github.com wrote:

Nice job! Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/go-ozzo/ozzo-validation/pull/39#issuecomment-359117239, or mute the thread https://github.com/notifications/unsubscribe-auth/AArbL99Yy3--Zqwa6KypCld8i0IPkx0iks5tMSOXgaJpZM4RlEfW .