search

go-p5 / p5

p5 is a simple package that provides primitives resembling the ones exposed by p5js.org
https://go-p5.github.io/
BSD 3-Clause "New" or "Revised" License
146 stars 12 forks source link

p5: expose number of frames displayed #33

Closed psampaz closed 3 years ago

psampaz commented 3 years ago

closes #32

codecov[bot] commented 3 years ago

Codecov Report

Merging #33 (542a85b) into main (fea8ed5) will increase coverage by 0.16%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   75.69%   75.86%   +0.16%     
==========================================
  Files           9        9              
  Lines         572      580       +8     
==========================================
+ Hits          433      440       +7     
- Misses        119      120       +1     
  Partials       20       20
Impacted Files Coverage Δ
api.go 68.18% <0.00%> (-3.25%) :arrow_down:
proc.go 54.63% <100.00%> (+1.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fea8ed5...542a85b. Read the comment docs.

sbinet commented 3 years ago

ah. could you rebase off the latest main? (just to make sure no "fat fingers" mistake happen on my side when I merge that PR)

thanks.

psampaz commented 3 years ago

I think I found a way to easily test Proc.run and control its execution. I will prepare a separate PR for this, and if it works out and get merged, I will rebase this and add the extra tests.

psampaz commented 3 years ago

closing in favour of #41