Add tests and description about usage of go 1.16 embed feature.

go-pg / migrations

SQL database migrations for Golang go-pg and PostgreSQL

https://godoc.org/github.com/go-pg/migrations

BSD 2-Clause "Simplified" License

309 stars 59 forks source link

Add tests and description about usage of go 1.16 embed feature. #101

Closed xakep666 closed 3 years ago

xakep666 commented 3 years ago

Nothing changed in a code. Just added new test/testdata and updated README.

TBD: DiscoverSQLMigrationsFromFilesystem and all under the hood may be refactored from http.FileSystem to fs.FS but it will break backwards compatibility.

vmihailenco commented 3 years ago

:+1: Thanks

tie commented 3 years ago

I don’t think that would work well, especially on Windows, because DiscoverSQLMigrationsFromFilesystem for some reason converts dir to absolute path using filepath.Abs.