search

go-ping / ping

ICMP Ping library for Go
MIT License
1.33k stars 345 forks source link

Use a guaranteed invalid hostname in TestNewPingerInvalid #113

Closed rrcollier closed 3 years ago

rrcollier commented 4 years ago

Cleaned up replacement PR for request #104.

CHTJonas commented 4 years ago

Not quite sure what's going on here and why you want to change this. The suite seems to run and pass every test, both locally for me and in our CI environment.

Does wtf resolve as a hostname on your network or something?! 😆

rrcollier commented 4 years ago

Ah, yes, I turns out there is a 'wtf' in one of my dns search paths. I have now updated my branch to use a guaranteed not to exists fqdn.