go-ping / ping

ICMP Ping library for Go
MIT License
1.33k stars 345 forks source link

Fix size issue when deserialising on Windows #144

Closed CHTJonas closed 3 years ago

CHTJonas commented 3 years ago

138 introduced some new behavior to make sure the data structure into which we deserialise ICMP messages is sized correctly. However it looks like there's some kind of weird incompatibility problem -- what works on Linux and macOS doesn't work on Windows unless the length of the IP packet header as also added on to the size.

This PR fixes #143 and makes the pinger work on Windows again.