search

go-ping / ping

ICMP Ping library for Go
MIT License
1.32k stars 344 forks source link

Log errors returned by recvICMP #160

Closed CHTJonas closed 3 years ago

CHTJonas commented 3 years ago

Currently we throw errors from the pinger.recvICMP function away which is very much non-ideal. While having a library print logs to the stdout is also far from ideal, it's arguably a less evil than not reporting them at all at least until such a time that we can implement a proper error-returning or logging interface (#16).

SuperQ commented 3 years ago

The other way we could handle this is to use an errgroup instead of a simple waitgroup.

CHTJonas commented 3 years ago

Rebased on top of the logger changes.

CHTJonas commented 3 years ago

Ping @sparrc for a review please! 🥺

CHTJonas commented 3 years ago

Superseded by ff8be3320020b96856d3d48505bcf8926809752e.