search

go-ping / ping

ICMP Ping library for Go
MIT License
1.33k stars 345 forks source link

Provide an abstraction over icmp.PacketConn #166

Closed mem closed 3 years ago

mem commented 3 years ago

The differences between ipv4 and ipv6 APIs can be moved to a single type so that we don't need to keep track of them all over the code.

Signed-off-by: Marcelo E. Magallon marcelo.magallon@grafana.com

mem commented 3 years ago

This is extracted from #158 in the hopes that it makes it easier to review. I had to modify the Run method to make it testable, and that's what making the change noisy, but I didn't want this to be intermingled with the other review.

SuperQ commented 3 years ago

Poke @CHTJonas