search

go-ping / ping

ICMP Ping library for Go
MIT License
1.33k stars 345 forks source link

Add ability to set TTL #175

Closed haylinmoore closed 3 years ago

haylinmoore commented 3 years ago

Recently I needed the ability to set the Ping TTL for a project and couldn't find a package that would let me to do that so I modified this to let me. This is probably useful to other people aswell so I figure why not make a PR. Could probably do with a little bit of reformating how the TTL is sent from the Pinger to the icmpConn.

haylinmoore commented 3 years ago

Hey, is anything gonna happen with this?

CHTJonas commented 3 years ago

ENOTUITS. Haven't forgotten but just very busy IRL at the moment!

CHTJonas commented 3 years ago

Hi @hamptonmoore, we've recently merged into master. Please could you rebase this?

SuperQ commented 3 years ago

This needs a rebase now that #177 is merged.

cemremengu commented 3 years ago

@hamptonmoore I will rebase this in another branch if you are busy atm

CHTJonas commented 3 years ago

Closing in favour of #186

SuperQ commented 3 years ago

@hamptonmoore If you want to rebase this, go ahead.