Maintenance: add more linters to golangci-lint

go-ping / ping

ICMP Ping library for Go

MIT License

1.31k stars 344 forks source link

Maintenance: add more linters to golangci-lint #184

Closed qdm12 closed 1 year ago

qdm12 commented 2 years ago

Use a maphash source instead of time based global variable
Add exported wrapping errors
Add unexported wrapping errors to add more context to the errors
Small code changes to satisfy all linters (e.g. adding inlined constants)

qdm12 commented 2 years ago

@SuperQ I would suggest to trust golangci-lint and not disable-all and leave all of the default enabled, even if they are 'deprecated'. Golangci-lint will eventually remove them in an upcoming release.

I'll also remove the linters enabled by default (for now) which I manually listed so they get automatically removed when golangci-lint gets upgraded to a release removing deprecated ones.

qdm12 commented 2 years ago

Also I made https://github.com/qdm12/ping/pull/1 to save a few bytes for structures (the order of fields matter in Go), let me know if you want to merge that in this branch or just discard it, thanks!

SuperQ commented 2 years ago

This needs a rebase.

SuperQ commented 1 year ago

See https://github.com/go-ping/ping/pull/226