fixed sometimes failing test

go-ping / ping

ICMP Ping library for Go

MIT License

1.31k stars 344 forks source link

Closed Code-Hex closed 2 years ago

Code-Hex commented 2 years ago

I'm using an M1 Mac. Run the test, it will most likely fail.

The sleep in this line will always take 10ms.
- https://github.com/go-ping/ping/blob/6e2b003bffdda24160560abd59cc6dfa560ea96c/ping_test.go#L740
But I don't think there is any guarantee that the processing in runLoop will be completed within 12ms. Probably this is the reason.

sometimes run this command

$ go test -timeout 30s -run "TestRunOK" github.com/go-ping/ping -v -count=1

CHTJonas commented 2 years ago

Any chance you could please add a fmt.Println("stats.MinRtt:", stats.MinRtt) and tell us how long it actually takes?

Code-Hex commented 2 years ago

@CHTJonas Thanks for replied. But I don't have a passion for this library now. So I close this PR. Sorry.