search

go-ping / ping

ICMP Ping library for Go
MIT License
1.31k stars 344 forks source link

#195 count packets of which writes fail still as sent packets + exit run loop in case count is reached #196

Closed turtletramp closed 1 year ago

turtletramp commented 2 years ago

Based on my comparison about how ping in Ubuntu works here is a potential fix which counts packets that cannot be written still as sent packets. The result is equal statistics to standard ping command.

potentially fixes #195

This approach fails one of the already existing tests which I also modified.

Any suggestions on how to fix this differently is welcome.

turtletramp commented 2 years ago

I checked the circleci info and I do not see how I could fix these; looks like some updates happened and as a result some hashes do not match anymore.

SuperQ commented 2 years ago

Yea, looks like something broke with goreleaser. I will see if I can fix it.

On Mon, Jan 3, 2022, 02:27 turtletramp @.***> wrote:

I checked the circleci info and I do not see how I could fix these; looks like some updates happened and as a result some hashes do not match anymore.

— Reply to this email directly, view it on GitHub https://github.com/go-ping/ping/pull/196#issuecomment-1003824858, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKCNW2T6D7N75M4P46GLE3UUD3QVANCNFSM5LEJVWYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

SuperQ commented 1 year ago

See https://github.com/go-ping/ping/pull/226