Uber zap's logger does os.Exit() if Fatal() or Fatalf() is called. Since go-ping supports custom loggers and in my case I pass in Uber zap's logger this causes my entire application to exit. Removing Fatal() calls is safer. If we need to ensure this error is handled up the call chain we can panic() which is better since the code can recover from a panic. The code cannot recover from an os.Exit() call.
SuperQ
commented
1 year ago
Uber zap's logger does
os.Exit()ifFatal()orFatalf()is called. Since go-ping supports custom loggers and in my case I pass in Uber zap's logger this causes my entire application to exit. RemovingFatal()calls is safer. If we need to ensure this error is handled up the call chain we canpanic()which is better since the code can recover from a panic. The code cannot recover from anos.Exit()call.