search

go-pkgz / email

Email library to send simple messages
https://go-pkgz.umputun.dev/email/
MIT License
21 stars 6 forks source link

feat: support LOGIN auth mechanism #15

Closed gurza closed 1 year ago

gurza commented 1 year ago

Closes #14

umputun commented 1 year ago

I have added a few comments, mostly minor things. @paskal pls take a look too, thx

gurza commented 1 year ago

@paskal hi! I have resolved all umputun comments. Please review it

paskal commented 1 year ago

I'll review it this evening. In the meantime, could you please run golangci-lint run ./... locally and fix the discovered errors?

gurza commented 1 year ago

I'll review it this evening. In the meantime, could you please run golangci-lint run ./... locally and fix the discovered errors?

I have resolved golangci-lint errors. thx

gurza commented 1 year ago

@paskal hello! Have you had a chance to review the code? Any additional comments?

gurza commented 1 year ago

@umputun let's merge? )

umputun commented 1 year ago

@umputun let's merge? )

sure. Just two more things before we merge:

  1. Add info about new auth and a new option to the readme
  2. rebase commits (squash)
gurza commented 1 year ago

@umputun now this feature branch is rebased and ready to be squashed and merged

gurza commented 1 year ago

@umputun I forgot to write right away, I added an info about new auth option to README.md. Looks like you can merge the PR.