ErrSizedGroup (context, multierror)

go-pkgz / syncs

Concurrency and synchronization primitives

https://go-pkgz.umputun.dev/syncs/

MIT License

136 stars 13 forks source link

ErrSizedGroup (context, multierror) #11

Open razor-87 opened 10 months ago

razor-87 commented 10 months ago

Hi, yesterday I decided to take a closer look at the examples from the readme, in the process it turned out that the last example for ErrSizedGroup runs with an error cannot use func(ctx context.Context) error {…} (value of type func(ctx context.Context) error) as func() error value in argument to egrp.Go.

implement the correct logic for context cancellation
simplify the methods for the MultiError struct
tried to reduce the number of explicit locks

coveralls commented 10 months ago

Pull Request Test Coverage Report for Build 6737635799

62 of 62 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.1%) to 100.0%

Totals
Change from base Build 6286685592:	1.1%
Covered Lines:	183
Relevant Lines:	183

💛 - Coveralls

razor-87 commented 10 months ago

Error: "1 error(s) occurred: [0] {err from function 101}" does not contain "err from function 100"

hmm, again the same error in the test