Closed vvohra closed 6 years ago
Hey @vvohra
thanks for the PR, would you be able to fix the tests for ue
?
--- FAIL: TestPercent (0.00s)
ue_test.go:39: Expected '% -1.023,45' Got '% −1.023,45'
FAIL
FAIL github.com/go-playground/locales/eu 0.028s
Then I'll merge :)
P.S. Thanks I've had very little time to work on this lately, I definitely want to improve it, but rather than focusing on the XML I would like to convert this to use the CLDR JSON as most of the inheritance is already parsed and I can focus more on the library itself.
Hey! Similar to you, I also have limited availability. Because I felt the work to using JSON files is not trivial, I made the small changes for inheritance and loaded the latest data for now.
Let me know how you feel.
Change look great @vvohra Thanks, will try to merge it in the next couple of days.
./cmd/data
enHeritance
to be a list of maps for all current parents defined insupplementalData.xml
Maybe we can extract the parents from the XML instead of hard coding it?
I'm seeing new locales, I think that's expected?