search

go-playground / locales

:earth_americas: a set of locales generated from the CLDR Project which can be used independently or within an i18n package; these were built for use with, but not exclusive to https://github.com/go-playground/universal-translator
MIT License
270 stars 58 forks source link

Go 1.10: ru_test.go:932: Errorf call has arguments but no formatting directives #21

Closed nim-nim closed 6 years ago

nim-nim commented 6 years ago

Release 0.12.0 does not pass unit tests with Go 1.10. At least:

+ GOPATH=/builddir/build/BUILD/locales-0.12.0/_build:/usr/share/gocode
+ go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro  '\'''
# github.com/go-playground/locales/ru
./ru_test.go:932: Errorf call has arguments but no format
deankarn commented 6 years ago

Hey @nim-nim looks like it was a leftover error from the last PR, just release v0.12.1 so it should be fixed once you update :)

please let me know if it's working for you now as well :)

nim-nim commented 6 years ago

Sure, will retest now, thank you for caring!

nim-nim commented 6 years ago

Passes initial tests here too!

deankarn commented 6 years ago

👍