search

go-playground / validator

:100:Go Struct and Field validation, including Cross Field, Cross Struct, Map, Slice and Array diving
MIT License
16.41k stars 1.3k forks source link

Fix: #1112 URL validation accepts "http:" as valid url #1114

Closed Ivaka closed 1 year ago

Ivaka commented 1 year ago

Fixes Or Enhances

Fixes #1112

Make sure that you've checked the boxes below before you submit PR:

@go-playground/validator-maintainers

Benchmarks before:

GO111MODULE=on go test -bench=. -benchmem ./...
goos: linux
goarch: amd64
pkg: github.com/go-playground/validator/v10
cpu: AMD Ryzen 7 PRO 3700U w/ Radeon Vega Mobile Gfx
BenchmarkFieldSuccess-8                                         11801617            93.70 ns/op        0 B/op          0 allocs/op
BenchmarkFieldSuccessParallel-8                                 54093084            20.37 ns/op        0 B/op          0 allocs/op
BenchmarkFieldFailure-8                                          1362246           973.9 ns/op       200 B/op          4 allocs/op
BenchmarkFieldFailureParallel-8                                  6183358           176.7 ns/op       200 B/op          4 allocs/op
BenchmarkFieldArrayDiveSuccess-8                                 1000000          1645 ns/op         145 B/op          8 allocs/op
BenchmarkFieldArrayDiveSuccessParallel-8                         4890320           228.8 ns/op       145 B/op          8 allocs/op
BenchmarkFieldArrayDiveFailure-8                                 1000000          2394 ns/op         348 B/op         13 allocs/op
BenchmarkFieldArrayDiveFailureParallel-8                         2763897           410.4 ns/op       349 B/op         13 allocs/op
BenchmarkFieldMapDiveSuccess-8                                    602858          3888 ns/op         288 B/op         14 allocs/op
BenchmarkFieldMapDiveSuccessParallel-8                           2359784           516.7 ns/op       288 B/op         14 allocs/op
BenchmarkFieldMapDiveFailure-8                                    624718          3158 ns/op         376 B/op         13 allocs/op
BenchmarkFieldMapDiveFailureParallel-8                           2218954           495.2 ns/op       376 B/op         13 allocs/op
BenchmarkFieldMapDiveWithKeysSuccess-8                            534006          4128 ns/op         288 B/op         14 allocs/op
BenchmarkFieldMapDiveWithKeysSuccessParallel-8                   1714122           669.2 ns/op       288 B/op         14 allocs/op
BenchmarkFieldMapDiveWithKeysFailure-8                            459775          4310 ns/op         553 B/op         16 allocs/op
BenchmarkFieldMapDiveWithKeysFailureParallel-8                   1275787           958.4 ns/op       553 B/op         16 allocs/op
BenchmarkFieldCustomTypeSuccess-8                                1944307           584.1 ns/op        32 B/op          2 allocs/op
BenchmarkFieldCustomTypeSuccessParallel-8                       11220068           107.1 ns/op        32 B/op          2 allocs/op
BenchmarkFieldCustomTypeFailure-8                                1661941           680.6 ns/op       184 B/op          3 allocs/op
BenchmarkFieldCustomTypeFailureParallel-8                        6390658           203.3 ns/op       184 B/op          3 allocs/op
BenchmarkFieldOrTagSuccess-8                                     1000000          1131 ns/op          16 B/op          1 allocs/op
BenchmarkFieldOrTagSuccessParallel-8                             4221580           259.6 ns/op        16 B/op          1 allocs/op
BenchmarkFieldOrTagFailure-8                                     1393892           934.2 ns/op       216 B/op          5 allocs/op
BenchmarkFieldOrTagFailureParallel-8                             5197488           212.3 ns/op       216 B/op          5 allocs/op
BenchmarkStructLevelValidationSuccess-8                          2816329           452.1 ns/op        16 B/op          1 allocs/op
BenchmarkStructLevelValidationSuccessParallel-8                 17393395            75.46 ns/op       16 B/op          1 allocs/op
BenchmarkStructLevelValidationFailure-8                          1000000          1588 ns/op         264 B/op          7 allocs/op
BenchmarkStructLevelValidationFailureParallel-8                  4049802           292.1 ns/op       264 B/op          7 allocs/op
BenchmarkStructSimpleCustomTypeSuccess-8                         1250786           879.9 ns/op        32 B/op          2 allocs/op
BenchmarkStructSimpleCustomTypeSuccessParallel-8                 7151274           150.8 ns/op        32 B/op          2 allocs/op
BenchmarkStructSimpleCustomTypeFailure-8                          967278          2294 ns/op         416 B/op          9 allocs/op
BenchmarkStructSimpleCustomTypeFailureParallel-8                 2779010           420.0 ns/op       432 B/op         10 allocs/op
BenchmarkStructFilteredSuccess-8                                 1000000          1805 ns/op         248 B/op          7 allocs/op
BenchmarkStructFilteredSuccessParallel-8                         3521836           330.2 ns/op       248 B/op          7 allocs/op
BenchmarkStructFilteredFailure-8                                  902488          1346 ns/op         232 B/op          6 allocs/op
BenchmarkStructFilteredFailureParallel-8                         3735235           274.8 ns/op       232 B/op          6 allocs/op
BenchmarkStructPartialSuccess-8                                  1000000          1596 ns/op         240 B/op          5 allocs/op
BenchmarkStructPartialSuccessParallel-8                          4368409           264.4 ns/op       240 B/op          5 allocs/op
BenchmarkStructPartialFailure-8                                   717194          2519 ns/op         456 B/op         10 allocs/op
BenchmarkStructPartialFailureParallel-8                          2608501           469.6 ns/op       456 B/op         10 allocs/op
BenchmarkStructExceptSuccess-8                                    780676          2380 ns/op         456 B/op         10 allocs/op
BenchmarkStructExceptSuccessParallel-8                           4490192           246.6 ns/op       224 B/op          4 allocs/op
BenchmarkStructExceptFailure-8                                    976275          2091 ns/op         440 B/op          9 allocs/op
BenchmarkStructExceptFailureParallel-8                           2592588           469.4 ns/op       440 B/op          9 allocs/op
BenchmarkStructSimpleCrossFieldSuccess-8                         1000000          1123 ns/op          56 B/op          3 allocs/op
BenchmarkStructSimpleCrossFieldSuccessParallel-8                 5899574           202.4 ns/op        56 B/op          3 allocs/op
BenchmarkStructSimpleCrossFieldFailure-8                          851788          1740 ns/op         272 B/op          8 allocs/op
BenchmarkStructSimpleCrossFieldFailureParallel-8                 3188026           368.7 ns/op       272 B/op          8 allocs/op
BenchmarkStructSimpleCrossStructCrossFieldSuccess-8              1000000          1578 ns/op          64 B/op          4 allocs/op
BenchmarkStructSimpleCrossStructCrossFieldSuccessParallel-8      4619691           241.5 ns/op        64 B/op          4 allocs/op
BenchmarkStructSimpleCrossStructCrossFieldFailure-8               829128          2893 ns/op         288 B/op          9 allocs/op
BenchmarkStructSimpleCrossStructCrossFieldFailureParallel-8      2677923           398.1 ns/op       288 B/op          9 allocs/op
BenchmarkStructSimpleSuccess-8                                   3592005           345.2 ns/op         0 B/op          0 allocs/op
BenchmarkStructSimpleSuccessParallel-8                          14831719            76.84 ns/op        0 B/op          0 allocs/op
BenchmarkStructSimpleFailure-8                                    795216          2249 ns/op         416 B/op          9 allocs/op
BenchmarkStructSimpleFailureParallel-8                           2835547           390.4 ns/op       416 B/op          9 allocs/op
BenchmarkStructComplexSuccess-8                                   459040          5754 ns/op         288 B/op          9 allocs/op
BenchmarkStructComplexSuccessParallel-8                          1591882           695.9 ns/op       288 B/op          9 allocs/op
BenchmarkStructComplexFailure-8                                   101236         14735 ns/op        3105 B/op         52 allocs/op
BenchmarkStructComplexFailureParallel-8                           419730          2822 ns/op        3105 B/op         52 allocs/op
BenchmarkOneof-8                                                 7499676           159.7 ns/op         0 B/op          0 allocs/op
BenchmarkOneofParallel-8                                        25018995            44.49 ns/op        0 B/op          0 allocs/op

Benchmarks after:

GO111MODULE=on go test -bench=. -benchmem ./...
goos: linux
goarch: amd64
pkg: github.com/go-playground/validator/v10
cpu: AMD Ryzen 7 PRO 3700U w/ Radeon Vega Mobile Gfx
BenchmarkFieldSuccess-8                                         12974497            92.64 ns/op        0 B/op          0 allocs/op
BenchmarkFieldSuccessParallel-8                                 46178876            22.92 ns/op        0 B/op          0 allocs/op
BenchmarkFieldFailure-8                                          1345202           921.7 ns/op       200 B/op          4 allocs/op
BenchmarkFieldFailureParallel-8                                  6294452           174.0 ns/op       200 B/op          4 allocs/op
BenchmarkFieldArrayDiveSuccess-8                                 1000000          1610 ns/op         145 B/op          8 allocs/op
BenchmarkFieldArrayDiveSuccessParallel-8                         4974109           223.0 ns/op       145 B/op          8 allocs/op
BenchmarkFieldArrayDiveFailure-8                                 1000000          2327 ns/op         348 B/op         13 allocs/op
BenchmarkFieldArrayDiveFailureParallel-8                         2909164           399.9 ns/op       349 B/op         13 allocs/op
BenchmarkFieldMapDiveSuccess-8                                    551305          3845 ns/op         288 B/op         14 allocs/op
BenchmarkFieldMapDiveSuccessParallel-8                           2488228           467.0 ns/op       288 B/op         14 allocs/op
BenchmarkFieldMapDiveFailure-8                                    772414          3410 ns/op         376 B/op         13 allocs/op
BenchmarkFieldMapDiveFailureParallel-8                           2193524           488.3 ns/op       376 B/op         13 allocs/op
BenchmarkFieldMapDiveWithKeysSuccess-8                            642025          3966 ns/op         288 B/op         14 allocs/op
BenchmarkFieldMapDiveWithKeysSuccessParallel-8                   1863225           554.4 ns/op       288 B/op         14 allocs/op
BenchmarkFieldMapDiveWithKeysFailure-8                            559651          4328 ns/op         553 B/op         16 allocs/op
BenchmarkFieldMapDiveWithKeysFailureParallel-8                   1647622           683.6 ns/op       553 B/op         16 allocs/op
BenchmarkFieldCustomTypeSuccess-8                                2121175           616.3 ns/op        32 B/op          2 allocs/op
BenchmarkFieldCustomTypeSuccessParallel-8                       11822690            93.81 ns/op       32 B/op          2 allocs/op
BenchmarkFieldCustomTypeFailure-8                                1485889           797.6 ns/op       184 B/op          3 allocs/op
BenchmarkFieldCustomTypeFailureParallel-8                        7947081           148.4 ns/op       184 B/op          3 allocs/op
BenchmarkFieldOrTagSuccess-8                                     1000000          1167 ns/op          16 B/op          1 allocs/op
BenchmarkFieldOrTagSuccessParallel-8                             4742452           218.4 ns/op        16 B/op          1 allocs/op
BenchmarkFieldOrTagFailure-8                                     1203343          1057 ns/op         216 B/op          5 allocs/op
BenchmarkFieldOrTagFailureParallel-8                             5406589           204.8 ns/op       216 B/op          5 allocs/op
BenchmarkStructLevelValidationSuccess-8                          3298723           489.8 ns/op        16 B/op          1 allocs/op
BenchmarkStructLevelValidationSuccessParallel-8                 14399948            74.10 ns/op       16 B/op          1 allocs/op
BenchmarkStructLevelValidationFailure-8                          1000000          1513 ns/op         264 B/op          7 allocs/op
BenchmarkStructLevelValidationFailureParallel-8                  4103812           278.4 ns/op       264 B/op          7 allocs/op
BenchmarkStructSimpleCustomTypeSuccess-8                         1406757          1091 ns/op          32 B/op          2 allocs/op
BenchmarkStructSimpleCustomTypeSuccessParallel-8                 7505160           141.8 ns/op        32 B/op          2 allocs/op
BenchmarkStructSimpleCustomTypeFailure-8                          883422          2300 ns/op         416 B/op          9 allocs/op
BenchmarkStructSimpleCustomTypeFailureParallel-8                 2746707           415.6 ns/op       432 B/op         10 allocs/op
BenchmarkStructFilteredSuccess-8                                 1000000          1779 ns/op         248 B/op          7 allocs/op
BenchmarkStructFilteredSuccessParallel-8                         3896308           302.1 ns/op       248 B/op          7 allocs/op
BenchmarkStructFilteredFailure-8                                 1000000          1517 ns/op         232 B/op          6 allocs/op
BenchmarkStructFilteredFailureParallel-8                         4696162           246.0 ns/op       232 B/op          6 allocs/op
BenchmarkStructPartialSuccess-8                                  1000000          1636 ns/op         240 B/op          5 allocs/op
BenchmarkStructPartialSuccessParallel-8                          4503459           255.5 ns/op       240 B/op          5 allocs/op
BenchmarkStructPartialFailure-8                                   857544          2530 ns/op         456 B/op         10 allocs/op
BenchmarkStructPartialFailureParallel-8                          2814386           415.4 ns/op       456 B/op         10 allocs/op
BenchmarkStructExceptSuccess-8                                    712800          2558 ns/op         456 B/op         10 allocs/op
BenchmarkStructExceptSuccessParallel-8                           4881768           231.8 ns/op       224 B/op          4 allocs/op
BenchmarkStructExceptFailure-8                                    980643          2203 ns/op         440 B/op          9 allocs/op
BenchmarkStructExceptFailureParallel-8                           3072993           393.5 ns/op       440 B/op          9 allocs/op
BenchmarkStructSimpleCrossFieldSuccess-8                         1000000          1350 ns/op          56 B/op          3 allocs/op
BenchmarkStructSimpleCrossFieldSuccessParallel-8                 6480792           163.9 ns/op        56 B/op          3 allocs/op
BenchmarkStructSimpleCrossFieldFailure-8                          890593          2411 ns/op         272 B/op          8 allocs/op
BenchmarkStructSimpleCrossFieldFailureParallel-8                 3336048           365.9 ns/op       272 B/op          8 allocs/op
BenchmarkStructSimpleCrossStructCrossFieldSuccess-8               839727          1641 ns/op          64 B/op          4 allocs/op
BenchmarkStructSimpleCrossStructCrossFieldSuccessParallel-8      4652806           237.4 ns/op        64 B/op          4 allocs/op
BenchmarkStructSimpleCrossStructCrossFieldFailure-8               680821          3032 ns/op         288 B/op          9 allocs/op
BenchmarkStructSimpleCrossStructCrossFieldFailureParallel-8      2641432           409.4 ns/op       288 B/op          9 allocs/op
BenchmarkStructSimpleSuccess-8                                   3409771           375.2 ns/op         0 B/op          0 allocs/op
BenchmarkStructSimpleSuccessParallel-8                          14754860            81.12 ns/op        0 B/op          0 allocs/op
BenchmarkStructSimpleFailure-8                                    802147          2292 ns/op         416 B/op          9 allocs/op
BenchmarkStructSimpleFailureParallel-8                           2884316           390.0 ns/op       416 B/op          9 allocs/op
BenchmarkStructComplexSuccess-8                                   407000          5694 ns/op         288 B/op          9 allocs/op
BenchmarkStructComplexSuccessParallel-8                          1722357           686.1 ns/op       288 B/op          9 allocs/op
BenchmarkStructComplexFailure-8                                   105184         14341 ns/op        3105 B/op         52 allocs/op
BenchmarkStructComplexFailureParallel-8                           435258          2783 ns/op        3105 B/op         52 allocs/op
BenchmarkOneof-8                                                 6750638           175.3 ns/op         0 B/op          0 allocs/op
BenchmarkOneofParallel-8                                        25553877            45.96 ns/op        0 B/op          0 allocs/op

The fix doesn't appear to affect the overall performance.

coveralls commented 1 year ago

Coverage Status

coverage: 73.96% (+0.002%) from 73.958% when pulling a73ffedae08be0abf7ec5b39987fc5d75bcde387 on Ivaka:master into ce28d7c4b27fbcafff82bc87a8bf58257beb9030 on go-playground:master.