Unnecessary lock operation for reading from cache in extractStructCache method - fixed double checknig/reading cStruct in validateStruct method

go-playground / validator

:100:Go Struct and Field validation, including Cross Field, Cross Struct, Map, Slice and Array diving

MIT License

16.98k stars 1.33k forks source link

Unnecessary lock operation for reading from cache in extractStructCache method - fixed double checknig/reading cStruct in validateStruct method #1236

Closed amirkaramiit closed 3 months ago

amirkaramiit commented 9 months ago

Fixes Or Enhances

Fixed unnecessary Lock, and UnLock Operations in *Validate.extractStructCache method while the struct (cStruct) has been cached.
Fixed double-checking structCache for a Cached struct in *validate.validateStruct method, while it was done in *Validate.extractStructCache method.

Make sure that you've checked the boxes below before you submit PR:

[x] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

coveralls commented 9 months ago

coverage: 74.167% (-0.005%) from 74.172% when pulling e83b4030e567b76564ceec982218475b875ced76 on amirkaramiit:validator-extractCStruct-get-duplicate into b328f72e15814aba56e018c06675b8d679ad6e90 on go-playground:master.