go-playground / validator

:100:Go Struct and Field validation, including Cross Field, Cross Struct, Map, Slice and Array diving
MIT License
16.06k stars 1.29k forks source link

Fix Japanese translation of max-items, lt-items and lte-items error #1250

Closed Tomoki108 closed 1 month ago

Tomoki108 commented 2 months ago

Fixes

In English version, max-items error message is "{0} must contain at maximum {1}". (ref) And current Japanese translation "{0}は最大でも{1}を含まなければなりません" is strait translation of English version but quite unnatural for Japanese.

We don’t usually use a sentence like "含まなければなりません" ("must contain") in this context. Because it can not "contain" any items further. So, we simply say "{0}は最大でも{1}でなければなりません" ("{0} must be at maximum {1}") instead.

"lt-items" and "lte-items" messages have same issue as above. (if those errors occur, it can not contain any items further as well.)


Make sure that you've checked the boxes below before you submit PR:

@go-playground/validator-maintainers

coveralls commented 2 months ago

Coverage Status

coverage: 74.208%. remained the same when pulling dd22b676cc7b1735c00699ae89cad9408bfab4f2 on Tomoki108:fix-ja-translator into a0f74b0fb2a7ae1750c0f0b0a49550d8b6e2e708 on go-playground:master.