search

go-playground / validator

:100:Go Struct and Field validation, including Cross Field, Cross Struct, Map, Slice and Array diving
MIT License
16.05k stars 1.29k forks source link

remove go 1.17 from CI tests job #1263

Closed alexandear closed 1 month ago

alexandear commented 1 month ago

Fixes Or Enhances

Removes Go 1.17 from the test CI job to speed up pipeline execution.

Testing with Go 1.17 is not needed because the minimum supported version is Go 1.18, as stated in the go.mod.

@go-playground/validator-maintainers

coveralls commented 1 month ago

Coverage Status

coverage: 74.243%. remained the same when pulling c1314b801664ea7b32738386229134c892057e88 on alexandear:ci-remove-go-1-17 into e20b94842ab102ba94e73eaf66f5c0466e405882 on go-playground:master.

deankarn commented 1 month ago

@alexandear this is a common misconception, but thank you for the PR.

It only became mandatory in Go 1.21+ Before Go 1.21, the directive was advisory only; now it is a mandatory requirement asserted in the Go Mod Reference https://go.dev/doc/modules/gomod-ref

And so versions prior to Go 1.21, including Go 1.17 are still supported by this package and the CI test is here to ensure no breaking changes are made to the package and Go 1.17 users.

It's an unfortunate and confusing state of affairs :(

Also see this previous comment with similar/related content https://github.com/go-playground/validator/issues/1225#issuecomment-1955841240

alexandear commented 1 month ago

@deankarn thanks for detailed response. Maybe it's better to set go 1.17 in go.mod? So, everyone knows Go 1.17 is supported by the library.