fix: fix some base32 parsing issues by using go standard library instead of regex

go-playground / validator

:100:Go Struct and Field validation, including Cross Field, Cross Struct, Map, Slice and Array diving

MIT License

17k stars 1.33k forks source link

fix: fix some base32 parsing issues by using go standard library instead of regex #1286

Open jamesatkin-myndup opened 5 months ago

jamesatkin-myndup commented 5 months ago

Fixes Or Enhances

Some strings were failing to be parsed by the previous RegEx based validation. This now uses the Go base32 module (part of the standard library) to more reliably decode the field.

Make sure that you've checked the boxes below before you submit PR:

[X] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

coveralls commented 5 months ago

coverage: 74.3% (+0.009%) from 74.291% when pulling 14dc59551c424e2046da88f29db79ce88519fec7 on jamesatkin-myndup:master into a947377040f8ebaee09f20d09a745ec369396793 on go-playground:master.

coveralls commented 5 months ago

coverage: 74.297% (+0.006%) from 74.291% when pulling c17835f6d05e54d845e3c0803a7c74be18a2ca41 on jamesatkin-myndup:master into a947377040f8ebaee09f20d09a745ec369396793 on go-playground:master.