search

go-playground / validator

:100:Go Struct and Field validation, including Cross Field, Cross Struct, Map, Slice and Array diving
MIT License
16.98k stars 1.33k forks source link

feat(#1291): upgrade mimetype dependency version for secure #1292

Open 9ssi7 opened 4 months ago

9ssi7 commented 4 months ago

Fixes Or Enhances

the mimetype dependency version upgraded.

Check for details https://github.com/go-playground/validator/issues/1291

@go-playground/validator-maintainers

9ssi7 commented 4 months ago

When I looked into it a bit, the mimetype repo started using bytes.Cut with version 1.4.4.

bytes.Cut came with version 1.18 of go. Check for details. Therefore, an error occurs in version 1.17.

We can remove 1.17 from the supported versions. Since 1.17 is already available for older versions, this will not be a problem.

coveralls commented 4 months ago

Coverage Status

coverage: 74.291%. remained the same when pulling 630d293a73cc1ca070f27b55cd7026ceb8290e95 on 9ssi7:master into a947377040f8ebaee09f20d09a745ec369396793 on go-playground:master.

9ssi7 commented 4 months ago

Yes, what I wrote in my previous comment is no longer valid. We used the module replace feature, which is a better way. This way, we can continue to support 1.17.

Now we just need to include this pr for security