search

go-playground / webhooks

:fishing_pole_and_fish: Webhook receiver for GitHub, Bitbucket, GitLab, Gogs
MIT License
950 stars 238 forks source link

Modify Gitlab Job and Pipeline events #123

Closed shaheed121 closed 3 years ago

shaheed121 commented 3 years ago

Modify Pipeline events and Job events payload as per https://docs.gitlab.com/ee/user/project/integrations/webhooks.html

shaheed121 commented 3 years ago

@Toshik1978 @deankarn Could you all take a look at this please?

Toshik1978 commented 3 years ago

@shaheed121 will review this week!

Toshik1978 commented 3 years ago

@shaheed121 interesting situation. Commonly your changes are backward incompatible. The question is how current code can be used at all... If smbd. by some reasons used it (it should not work, but...), than it's a problem )

shaheed121 commented 3 years ago

Changes to job events was merged in Gitlab on Aug 29, 2019. Also, changes to pipeline events to use builds instead of jobs happened on May 23, 2019. So it hasn't been working for a while. I have made more additions and removed deprecated keys that are not being in use.

@Toshik1978 So could you please release a major version release of the library with note on backward incompatible change for Gitlab?

Toshik1978 commented 3 years ago

@shaheed121 I'm almost agree with you. We already have several PRs with breaking changes. But I want to sync it with @deankarn. Dean, what do you think? I'm ready to release v6 commonly

shaheed121 commented 3 years ago

@Toshik1978 @deankarn Do you think you can provide some love to this? :)

Toshik1978 commented 3 years ago

@deankarn yeap, definitely will review all latest PRs with incompatible changes and release at once! @shaheed121 I'll try to release new major version this week.