search

go-playground / webhooks

:fishing_pole_and_fish: Webhook receiver for GitHub, Bitbucket, GitLab, Gogs
MIT License
950 stars 238 forks source link

Changed date field from int64 to time.Time to fix the parsing error. #144

Closed iamsumit closed 2 years ago

iamsumit commented 2 years ago

Related issue: https://github.com/go-playground/webhooks/issues/47

This PR fixes the parse error for installation repositories event for date fields by using time.Time instead of int64 type.

deankarn commented 2 years ago

@iamsumit would you be able to update the tests to use the new GitHub output? the tests seem to be failing.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 88.208% when pulling b793bbfed1fd0c9ddd31ac45d59370f21ee6345f on iamsumit:issue-47 into 9c954e23a1b901399c0f9d71645f84d3287641ca on go-playground:master.

iamsumit commented 2 years ago

@iamsumit would you be able to update the tests to use the new GitHub output? the tests seem to be failing.

I fixed the tests. However, the integration_installation and integration_installation_repo events were failing due to the same issue. There is no such events listed on the github docs.

alehechka commented 2 years ago

Running into this same issue. I was able to replace the dependency with your fork, but wondering what the approval process is to get this merged in?