go-playground / webhooks

:fishing_pole_and_fish: Webhook receiver for GitHub, Bitbucket, GitLab, Gogs
MIT License
950 stars 238 forks source link

chore: update Go version to 1.17 #182

Closed robinlieb closed 11 months ago

coveralls commented 1 year ago

Coverage Status

coverage: 88.697%. remained the same when pulling f60d7b2678fa0678037ddc32f8086b282dbe3a60 on robinlieb:feat/go-1.20-update into 10570b0a59e87d2ac7ec6f708e59c577f026a59d on go-playground:master.

Toshik1978 commented 1 year ago

@robinlieb I think webhooks never defined the minimal Golang version it supported. So now it would be 1.16 for sure. Just want to pay attention if we are OK with it.

robinlieb commented 1 year ago

@Toshik1978 would also make sense to use 1.17, the minimal version set in the workflow.yaml, and keep them in sync? Than I would update this PR / create a new one to set the Go version to 1.17.

Toshik1978 commented 1 year ago

Yes, let's do it! Thanks! You can use this PR or create a new one. It's up to you!

robinlieb commented 1 year ago

@Toshik1978 used this one and updated it to 1.17.