go-python / gpython

gpython is a python interpreter written in go "batteries not included"
BSD 3-Clause "New" or "Revised" License
869 stars 95 forks source link

fix+enhanced py.ParseTupleAndKeywords() #152

Closed drew-512 closed 2 years ago

drew-512 commented 2 years ago

Fixes keyword arg parsing for py.ParseTupleAndKeywords(), exposed by tests added in: PR151

GC load enhancement: parseFormat() no longer makes allocations, eliminating (often) multiple allocations per call.

codecov[bot] commented 2 years ago

Codecov Report

Merging #152 (af5c88f) into master (965bc08) will increase coverage by 0.00%. The diff coverage is 78.04%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   74.54%   74.55%           
=======================================
  Files          64       64           
  Lines       11182    11191    +9     
=======================================
+ Hits         8336     8343    +7     
- Misses       2296     2297    +1     
- Partials      550      551    +1     
Impacted Files Coverage Δ
py/args.go 63.00% <78.04%> (+1.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 965bc08...af5c88f. Read the comment docs.

sbinet commented 2 years ago

superceded by #151