search

go-python / gpython

gpython is a python interpreter written in go "batteries not included"
BSD 3-Clause "New" or "Revised" License
870 stars 95 forks source link

2022 examples tests cleanup #191

Closed drew-512 closed 2 years ago

drew-512 commented 2 years ago

enhancements to package pytest and embedded golden cleanup

drew-512 commented 2 years ago

Soon to follow after this branch is a PR that does a golden test for the multi-context π example...

codecov[bot] commented 2 years ago

Codecov Report

Merging #191 (3d9b125) into main (80944be) will increase coverage by 0.52%. The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   73.80%   74.33%   +0.52%     
==========================================
  Files          76       76              
  Lines       12519    12560      +41     
==========================================
+ Hits         9240     9336      +96     
+ Misses       2624     2557      -67     
- Partials      655      667      +12
Impacted Files Coverage Δ
pytest/pytest.go 55.81% <59.25%> (+5.81%) :arrow_up:
examples/embedding/mylib.module.go 82.81% <100.00%> (+53.12%) :arrow_up:
stdlib/stdlib.go 57.89% <0.00%> (+3.00%) :arrow_up:
py/module.go 75.47% <0.00%> (+3.77%) :arrow_up:
py/util.go 26.31% <0.00%> (+21.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80944be...3d9b125. Read the comment docs.

drew-512 commented 2 years ago

Lmk what works from here.

I'm thinking this PR is now good (unless I missed something in your above comments), or I can expand this PR and add the testing for the multi-context test which makes uses of pytest.Task.

drew-512 commented 2 years ago

Was holding off on the next branch to do the next branch that tests multi-ctx. Should I keep waiting or start adding that to this branch?

sbinet commented 2 years ago

sorry, I am back from holidays. taking a look at it now.

sbinet commented 2 years ago

there were too many rebase conflicts.

I have created https://github.com/go-python/gpython/pull/192.

sbinet commented 2 years ago

superseded by https://github.com/go-python/gpython/pull/192.