search

go-python / gpython

gpython is a python interpreter written in go "batteries not included"
BSD 3-Clause "New" or "Revised" License
870 stars 95 forks source link

Add os.listdir #216

Closed reyoung closed 1 year ago

reyoung commented 1 year ago

@sbinet @glaukiol1

Please take a review, thanks

codecov[bot] commented 1 year ago

Codecov Report

Base: 74.38% // Head: 74.38% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (41b8ddf) compared to base (0cc4032). Patch coverage: 74.19% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #216 +/- ## ========================================== - Coverage 74.38% 74.38% -0.01% ========================================== Files 76 76 Lines 12625 12656 +31 ========================================== + Hits 9391 9414 +23 - Misses 2562 2567 +5 - Partials 672 675 +3 ``` | [Impacted Files](https://codecov.io/gh/go-python/gpython/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-python) | Coverage Δ | | |---|---|---| | [stdlib/os/os.go](https://codecov.io/gh/go-python/gpython/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-python#diff-c3RkbGliL29zL29zLmdv) | `67.72% <74.19%> (+0.70%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-python). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-python)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

reyoung commented 1 year ago

Perhaps py.ParseTupleAndKeywords needs more comments. It is hard to understand how to set the format parameter.

:-)

reyoung commented 1 year ago

Oh, I see..

py.ParseTupleAndKeywords is just like CPython API ParseTupleAndKeywords.

Perhaps need a comment to show that.

reyoung commented 1 year ago

Here is the PR for contributors https://github.com/go-python/license/pull/20 .