search

go-python / gpython

gpython is a python interpreter written in go "batteries not included"
BSD 3-Clause "New" or "Revised" License
870 stars 95 forks source link

add lower() and upper for py str feat:(#232) #233

Closed wdq112 closed 6 months ago

wdq112 commented 6 months ago

add lower() and upper for py str

Updates #232

wdq112 commented 6 months ago

feat #232

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.47%. Comparing base (23c0aa2) to head (e40546f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #233 +/- ## ========================================== + Coverage 75.45% 75.47% +0.01% ========================================== Files 79 79 Lines 13214 13222 +8 ========================================== + Hits 9971 9979 +8 Misses 2568 2568 Partials 675 675 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sbinet commented 6 months ago

perhaps also add a test for upper and lower in py/tests/string.py, after: https://github.com/go-python/gpython/blob/23c0aa2/py/tests/string.py#L889...L898

(to appease the testing gods)

sbinet commented 6 months ago

needs https://github.com/go-python/license/pull/22

sbinet commented 6 months ago

Thanks a lot for this PR.

do you want to give the last leg of #232 (str.join) a try ? :}

wdq112 commented 6 months ago

I'll try it when I have time.