Closed ghost closed 10 years ago
A ran the test suite now and fixed a small bug. This change should now be safe to use.
Thanks for the changes. It's looking good. I've provided just a few comments we have to address. Please let me know if you're planning to do these soon.
Any news?
Found some free time to fix the PR.
This pull request fixes two issues with the obj.Call() method:
I haven't run the test suite yet for the double call fix, since the test suite is broken under Mac right now (upstream problem with the packaging of QT in homebrew), so I suggest waiting until I did a quick run on my desktop at home until I can verify if it runs cleanly. Please also check for the C++ style.