search

go-redis / redismock

Redis client Mock
https://redis.uptrace.dev
BSD 2-Clause "Simplified" License
280 stars 60 forks source link

add ExpectSetArgs method #34

Closed agammell closed 1 year ago

agammell commented 2 years ago

GETSET is considered a deprecated command in Redis 6.2.0 with the recommended replacement command being SET with the GET argument provided.

This preferred method is implemented in go-redis via the SetArgs function, which takes a SetArgs instance with the Get field set to true. But redismock does not currently support mocking the SetArgs function.

This PR implements an ExpectSetArgs functionality, allowing code written using it to be mocked.

fterrag commented 2 years ago

Hi there! What can we do to get this PR reviewed and merged? Thank you for opening this @agammell!

agammell commented 2 years ago

Is this repo still active?

agammell commented 1 year ago

Looks like this is now present in master. Closing the PR.