go-reform / reform

A better ORM for Go, based on non-empty interfaces and code generation.
https://gopkg.in/reform.v1
MIT License
1.44k stars 73 forks source link

Added Count() method for counting number of rows in a query #179

Closed skamenetskiy closed 5 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #179 into v1-4 will decrease coverage by 11.23%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            v1-4     #179       +/-   ##
==========================================
- Coverage   68.4%   57.16%   -11.24%     
==========================================
  Files         19       19               
  Lines       1557     1564        +7     
==========================================
- Hits        1065      894      -171     
- Misses       442      619      +177     
- Partials      50       51        +1
Impacted Files Coverage Δ
querier_selects.go 93.91% <100%> (-3.31%) :arrow_down:
reform-db/models.go 0% <0%> (-76.48%) :arrow_down:
reform-db/cmd_init.go 22.94% <0%> (-46.48%) :arrow_down:
reform-db/cmd_init_mssql.go 0% <0%> (-34.49%) :arrow_down:
reform-db/cmd_init_mysql.go 0% <0%> (-32.26%) :arrow_down:
reform-db/cmd_init_postgres.go 0% <0%> (-32%) :arrow_down:
reform-db/models_reform.go 38.6% <0%> (-23.42%) :arrow_down:
querier.go 94.82% <0%> (-5.18%) :arrow_down:
querier_commands.go 77.39% <0%> (-4.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 483142b...8449f81. Read the comment docs.

AlekSi commented 5 years ago

I will take it from there. :)

skamenetskiy commented 5 years ago

Sorry, didn’t have time to finish that one :)