go-rel / rel

:gem: Modern ORM for Golang - Testable, Extendable and Crafted Into a Clean and Elegant API
https://go-rel.github.io/
MIT License
744 stars 58 forks source link

Add query args to instrumentation #314

Closed wakamenod closed 1 year ago

wakamenod commented 1 year ago

I think it would be useful to have query parameters in the log output as well. What do you think?

Fs02 commented 1 year ago

looks like a breaking change 🤔

can you give some of your example requirements?

wakamenod commented 1 year ago

@Fs02

Hi, thanks for checking out.

can you give some of your example requirements?

Well, I think other ORM libraries such as gorm can output query log with parameters, and from my experience that was useful when you debug the application.

Fs02 commented 1 year ago

hmmm, fair enough

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (dd9c330) compared to base (001ce33). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #314 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 33 33 Lines 2766 2766 ========================================= Hits 2766 2766 ``` | [Impacted Files](https://codecov.io/gh/go-rel/rel/pull/314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-rel) | Coverage Δ | | |---|---|---| | [instrumentation.go](https://codecov.io/gh/go-rel/rel/pull/314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-rel#diff-aW5zdHJ1bWVudGF0aW9uLmdv) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-rel). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-rel)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.