Closed Fs02 closed 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
c4186df
) compared to base (eaad046
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hello I work of the R&D department at @ditrit we are very interested in this type of modifications. Currently we are implementing a Generic repository on top of gorm, which is far from ideal...
Hi @slashformotion, I'm glad that you are interested in this, this will be merged soon and support for go-rel/reltest
will also follow. the plan is to release this overall changes within this week or next week
if you've any feedback or improvement idea, let me know
for a cleaner git history you should probably not merge master into anything, you should rebase see this https://www.theserverside.com/blog/Coffee-Talk-Java-News-Stories-and-Opinions/How-to-Git-rebase-a-branch-to-master-example
I'm using squash merge, which have the same result as rebase with with much more cleaner commit history
(not to mention, it's easier to resolve even the worst conflict using merge commit while working in a PR branch)
also, with squash merge, there's no need to enable "allow force-push", which I'm very against with 🙈
interesting , I will look into it