Fix#383: initial change to make SetHeader() thread safe

go-resty / resty

Simple HTTP and REST client library for Go

MIT License

9.89k stars 696 forks source link

Fix#383: initial change to make SetHeader() thread safe #717

Closed amarjeetanandsingh closed 11 months ago

amarjeetanandsingh commented 11 months ago

Not only the SetHeader(), but we may need to consider other APIs too.

jeevatkm commented 11 months ago

@amarjeetanandsingh, I appreciate your interest in creating PR.

This PR is not a solution. A complete resty client object should be made thread-safe with global read-write Mutex. This approach will result in a few breaking changes, which I'm parking for v3.0.0 development. So, I will close this PR.