search

go-resty / resty

Simple HTTP and REST client library for Go
MIT License
10.01k stars 706 forks source link

fix: do not use errors.Join, just use custom error approach #863

Closed jeevatkm closed 3 weeks ago

jeevatkm commented 3 weeks ago

As it turns out, errors.Join is not playing well with simple errors like errors.New or fmt.Errorf. For now, let's go with a custom error with Unwrap.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.15%. Comparing base (5d33e1a) to head (33f6035). Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
client.go 50.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2 #863 +/- ## ========================================== - Coverage 96.23% 96.15% -0.09% ========================================== Files 14 14 Lines 1808 1821 +13 ========================================== + Hits 1740 1751 +11 - Misses 45 46 +1 - Partials 23 24 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.