search

go-semantic-release / semantic-release

📦🚀 semantic-release written in Go
https://go-semantic-release.xyz
MIT License
404 stars 43 forks source link

fix: npm defaults #114

Closed cliedeman closed 2 years ago

cliedeman commented 2 years ago

Remove default for files-updater

It does nothin without --update package.json being set as well

christophwitzko commented 2 years ago

Hey, but this will break if people were using --update package.json and assuming the npm plugin is loaded. 🤔 Also, the npm plugin is lazy-loaded, so if the --update flag is missing it is not downloaded/started

cliedeman commented 2 years ago

Hi @christophwitzko

so this happpend to me. I guess its just confusing that the npm file updater plugin is loaded by default but without --update nothing happens.

Maybe a warning that file updater plugins are loaded but there are no files marked for update?

christophwitzko commented 2 years ago

A warning sounds great 👍 Can you tackle this?

cliedeman commented 2 years ago

Sure. See https://github.com/go-semantic-release/semantic-release/pull/115