search

go-semantic-release / semantic-release

📦🚀 semantic-release written in Go
https://go-semantic-release.xyz
MIT License
404 stars 43 forks source link

Providing files-updater-helm plugin #124

Closed SISheogorath closed 2 years ago

SISheogorath commented 2 years ago

I wrote a plugin for go-semantic-release to update helm versions (https://git.shivering-isles.com/sheogorath/files-updater-helm).

While I can obviously maintain it in my own repository, I would like to push this upstream into the go-semantic-release organisation and maintain it in here. I wonder what's your opinion on that.

Note: I'm not the greatest go writer in the world, so general feedback is appreciated.

christophwitzko commented 2 years ago

Hi @SISheogorath, this is amazing. 🎉 Thank you ☺️ I will create a repository for you and once the release/build process works, I will add it to the plugin registry. I also checked out your code and it looks very good. Just found one little thing at https://git.shivering-isles.com/sheogorath/files-updater-helm/-/blob/main/pkg/updater/helm.go#L36 Why is there no error handling?

Cheers, Chris

SISheogorath commented 2 years ago

Thanks! I added the content to the repository, updated the required fields and fixed the missing error handling!

Looking forward to work on this :)

christophwitzko commented 2 years ago

Awesome, I also added the plugin to the plugin registry. 👍 Thanks for contributing a new plugin 🎉