search

go-semantic-release / semantic-release

📦🚀 semantic-release written in Go
https://go-semantic-release.xyz
MIT License
405 stars 43 forks source link

refactor: use testify #61

Closed cliedeman closed 4 years ago

cliedeman commented 4 years ago

@christophwitzko picked up an interesting failure. 

=== RUN   TestGithubValid
    TestGithubValid: github_test.go:12: 
            Error Trace:    github_test.go:12
            Error:          Error message not equal:
                            expected: "This test run is not running on a branch build."
                            actual  : "This test run was triggered on the branch refactor/testify, while semantic-release is configured to only publish from ."

Looks like the ci variables are leaking into the test

christophwitzko commented 4 years ago

@cliedeman Ahh, yeah. That's right. I fixed it.

christophwitzko commented 4 years ago

Looks good, thank you 👍